Skip to content

Bump bootstrap_form from 2.7.0 to 5.4.0 #2073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dependabot wants to merge 1 commit into from
Closed

Bump bootstrap_form from 2.7.0 to 5.4.0 #2073

dependabot wants to merge 1 commit into from

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 31, 2023 •
edited
Loading

Bumps bootstrap_form from 2.7.0 to 5.4.0.

Release notes

Sourced from bootstrap_form's releases.

v5.4.0

Adds Rails 7.1.1+ to the test matrix, and upgrades the demo/test app to Rails 7.1.1. Miscellaneous fixes.

What's Changed

New features

  • Rails 7.1. No changes in functionality, but added Rails 7.1 to the test matrix and upgraded the demo/test app (#708).

Bugfixes

  • Do not alias rich text area if it is not defined (#709).
  • Fix joins not to make strings unsafe (#704).

Performance

Documentation

Development

  • Changes to the experimental Docker development environment. (#712, #710).

Full Changelog: bootstrap-ruby/bootstrap_form@v5.3.2...v5.4.0

Closed issues

New Contributors

v5.3.2

Bugfixes

Full Changelog: bootstrap-ruby/bootstrap_form@v5.3.1...v5.3.2

Closed issues

v5.3.1

Bugfix release

  • Allow settings conditional presence validators using symbols.

Full Changelog: bootstrap-ruby/bootstrap_form@v5.3.0...v5.3.1

Closed issues

v5.3.0

What's Changed

New features

... (truncated)

Changelog

Sourced from bootstrap_form's changelog.

Change Log

You can find recent releases with docs in GitHub:

https://github.com/bootstrap-ruby/bootstrap_form/releases

Diffs

Older releases

The tooling to support our old way of doing the change log doesn't work anymore, and we don't have a better solution, so this change log has become unreliable since version 4.5.0. Please refer to the commit history if you need to debug changes.

[Pending Release][]

Breaking changes

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Oct 31, 2023
@dependabot dependabot bot mentioned this pull request Oct 31, 2023
Closed
@codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (5277a4f) to head (970b54a).
⚠️ Report is 157 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2073   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files          55       55           
  Lines        2125     2125           
=======================================
  Hits         2124     2124           
  Misses          1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andrewfader
Copy link
Collaborator

andrewfader commented Dec 19, 2024

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 19, 2024

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@andrewfader
Copy link
Collaborator

andrewfader commented Dec 19, 2024

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/bundler/bootstrap_form-5.4.0 branch from c4cf5a6 to 55d49b2 Compare December 19, 2024 07:56
@andrewfader
Copy link
Collaborator

andrewfader commented Dec 23, 2024

@david-a-wheeler I think this is safe to do? Also probably needs visual checking?

@andrewfader
Copy link
Collaborator

andrewfader commented Dec 23, 2024

https://github.com/dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/bundler/bootstrap_form-5.4.0 branch from 55d49b2 to 35626aa Compare December 23, 2024 03:26
@andrewfader
Copy link
Collaborator

andrewfader commented Dec 23, 2024

@dependabot rebase

@dependabot
Bump bootstrap_form from 2.7.0 to 5.4.0
970b54a 
Bumps [bootstrap_form](https://github.com/bootstrap-ruby/bootstrap_form) from 2.7.0 to 5.4.0.
- [Release notes](https://github.com/bootstrap-ruby/bootstrap_form/releases)
- [Changelog](https://github.com/bootstrap-ruby/bootstrap_form/blob/main/CHANGELOG.md)
- [Commits](bootstrap-ruby/bootstrap_form@v2.7.0...v5.4.0)

---
updated-dependencies:
- dependency-name: bootstrap_form
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/bootstrap_form-5.4.0 branch from 35626aa to 970b54a Compare December 23, 2024 04:57
@david-a-wheeler
Copy link
Collaborator

david-a-wheeler commented Aug 24, 2025

No, this update is completely unsafe. We use Bootstrap version 3 for the UI.

It would probably take about 2 months to rewrite the code for newer versions of Bootstrap. That estimate is from Claude Code, and it sounds right.

The bootstrap_form CHANGELOG says:

4.0.0.alpha1 (2018-06-16)
🚨 This release adds support for Bootstrap v4 and drops support for Bootstrap v3. 🚨
If your app uses Bootstrap v3, you should continue using bootstrap_form 2.7.x instead.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 24, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/bundler/bootstrap_form-5.4.0 branch August 24, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewfader andrewfader andrewfader approved these changes

@david-a-wheeler david-a-wheeler Awaiting requested review from david-a-wheeler

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewfader @david-a-wheeler